ACPI: EC: Separate delays for MSI hardware
authorAlexey Starikovskiy <astarikovskiy@suse.de>
Wed, 1 Apr 2009 04:25:10 +0000 (00:25 -0400)
committerLen Brown <len.brown@intel.com>
Wed, 1 Apr 2009 04:25:10 +0000 (00:25 -0400)
MSI notebooks require very strict delays, while all others
are happy with msleep().

References: http://bugzilla.kernel.org/show_bug.cgi?id=9998

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/ec.c

index 2fe15060dcdc2c3a51dd9f3ef20171e0b4e50c8e..ac9dd3b386b1ee5fd663b64da9c96d325e363b84 100644 (file)
@@ -67,7 +67,7 @@ enum ec_command {
 
 #define ACPI_EC_DELAY          500     /* Wait 500ms max. during EC ops */
 #define ACPI_EC_UDELAY_GLK     1000    /* Wait 1ms max. to get global lock */
-#define ACPI_EC_UDELAY         100     /* Wait 100us before polling EC again */
+#define ACPI_EC_CDELAY         10      /* Wait 10us before polling EC */
 
 #define ACPI_EC_STORM_THRESHOLD 8      /* number of false interrupts
                                           per one transaction */
@@ -236,13 +236,23 @@ static int ec_check_sci(struct acpi_ec *ec, u8 state)
        return 0;
 }
 
+static void ec_delay(void)
+{
+       /* EC in MSI notebooks don't tolerate delays other than 550 usec */
+       if (EC_FLAGS_MSI)
+               udelay(ACPI_EC_DELAY);
+       else
+               /* Use shortest sleep available */
+               msleep(1);
+}
+
 static int ec_poll(struct acpi_ec *ec)
 {
        unsigned long delay = jiffies + msecs_to_jiffies(ACPI_EC_DELAY);
-       udelay(ACPI_EC_UDELAY);
+       udelay(ACPI_EC_CDELAY);
        while (time_before(jiffies, delay)) {
                gpe_transaction(ec, acpi_ec_read_status(ec));
-               udelay(ACPI_EC_UDELAY);
+               ec_delay();
                if (ec_transaction_done(ec))
                        return 0;
        }