ematch: Fix auto-loading of ematch modules.
authorIgnacy Gawędzki <ignacy.gawedzki@green-communications.fr>
Tue, 17 Feb 2015 19:15:20 +0000 (20:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Feb 2015 20:30:56 +0000 (15:30 -0500)
In tcf_em_validate(), after calling request_module() to load the
kind-specific module, set em->ops to NULL before returning -EAGAIN, so
that module_put() is not called again by tcf_em_tree_destroy().

Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
Acked-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/ematch.c

index 6742200b13071b6e63c200767a77a653d2e10c06..fbb7ebfc58c6761f6afb58e62646908b10e2bf09 100644 (file)
@@ -228,6 +228,7 @@ static int tcf_em_validate(struct tcf_proto *tp,
                                 * to replay the request.
                                 */
                                module_put(em->ops->owner);
+                               em->ops = NULL;
                                err = -EAGAIN;
                        }
 #endif