irqchip/gic-v3-its: Zero command on allocation
authorMarc Zyngier <marc.zyngier@arm.com>
Mon, 19 Dec 2016 17:16:45 +0000 (17:16 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Wed, 8 Feb 2017 17:09:56 +0000 (17:09 +0000)
When reusing commands from the ring buffer, it would be better
to zero them out, even if the ITS should ignore the unused
fields.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3-its.c

index ee928de49737635a91e58649bf5eeb042b4ddf96..4a895c6d68058b0b960c52cdbd6aaeadccc52369 100644 (file)
@@ -411,6 +411,12 @@ static struct its_cmd_block *its_allocate_entry(struct its_node *its)
        if (its->cmd_write == (its->cmd_base + ITS_CMD_QUEUE_NR_ENTRIES))
                its->cmd_write = its->cmd_base;
 
+       /* Clear command  */
+       cmd->raw_cmd[0] = 0;
+       cmd->raw_cmd[1] = 0;
+       cmd->raw_cmd[2] = 0;
+       cmd->raw_cmd[3] = 0;
+
        return cmd;
 }