leds: lp8501: make several arrays static const
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Aug 2017 13:00:55 +0000 (14:00 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Tue, 29 Aug 2017 19:10:39 +0000 (21:10 +0200)
Don't populate the arrays on the stack, instead make them static const.
Makes the object code smaller by 50 bytes:

Before:
   text    data     bss     dec     hex filename
   5058    1552      64    6674    1a12 drivers/leds/leds-lp8501.o

After:
   text    data     bss     dec     hex filename
   4788    1776      64    6628    19e4 drivers/leds/leds-lp8501.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-lp8501.c

index 3f9675bd214a404fcd5e771ed87bf4079dacf938..3adb113cf02e5d781bd395c57e1269a567a7b1d9 100644 (file)
@@ -118,19 +118,19 @@ static int lp8501_post_init_device(struct lp55xx_chip *chip)
 static void lp8501_load_engine(struct lp55xx_chip *chip)
 {
        enum lp55xx_engine_index idx = chip->engine_idx;
-       u8 mask[] = {
+       static const u8 mask[] = {
                [LP55XX_ENGINE_1] = LP8501_MODE_ENG1_M,
                [LP55XX_ENGINE_2] = LP8501_MODE_ENG2_M,
                [LP55XX_ENGINE_3] = LP8501_MODE_ENG3_M,
        };
 
-       u8 val[] = {
+       static const u8 val[] = {
                [LP55XX_ENGINE_1] = LP8501_LOAD_ENG1,
                [LP55XX_ENGINE_2] = LP8501_LOAD_ENG2,
                [LP55XX_ENGINE_3] = LP8501_LOAD_ENG3,
        };
 
-       u8 page_sel[] = {
+       static const u8 page_sel[] = {
                [LP55XX_ENGINE_1] = LP8501_PAGE_ENG1,
                [LP55XX_ENGINE_2] = LP8501_PAGE_ENG2,
                [LP55XX_ENGINE_3] = LP8501_PAGE_ENG3,