projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6e17c98)
Staging: iio: accel: sca3000: Fixed NULL comparison style
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sun, 13 Dec 2015 15:15:13 +0000 (18:15 +0300)
committerJonathan Cameron <jic23@kernel.org>
Sat, 19 Dec 2015 16:40:55 +0000 (16:40 +0000)
The variable u8 **rx_p, is a pointer-to-pointer and hence the check
should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which
was incorrect:
CHECK: Comparison to NULL could be written "!rx_p"
+       if (*rx_p == NULL) {

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/accel/sca3000_ring.c patch | blob | blame | history

diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 20b878d35ea2eca2929d14af75243f360e330a59..1920dc60cf3d2b4e879e11995355c42343b5e341 100644 (file)
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
                }
        };
        *rx_p = kmalloc(len, GFP_KERNEL);
-       if (*rx_p == NULL) {
+       if (!*rx_p) {
                ret = -ENOMEM;
                goto error_ret;
        }