selinux: Remove unnecessary check of array base in selinux_set_mapping()
authorMatthias Kaehlcke <mka@chromium.org>
Thu, 16 Mar 2017 22:26:52 +0000 (15:26 -0700)
committerPaul Moore <paul@paul-moore.com>
Wed, 29 Mar 2017 22:57:25 +0000 (18:57 -0400)
'perms' will never be NULL since it isn't a plain pointer but an array
of u32 values.

This fixes the following warning when building with clang:

security/selinux/ss/services.c:158:16: error: address of array
'p_in->perms' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
                while (p_in->perms && p_in->perms[k]) {

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/services.c

index b4aa491a0a23d8e025f00fde82b317952816773f..60d9b02523215aa37b0399e1446726e05b99cb8f 100644 (file)
@@ -157,7 +157,7 @@ static int selinux_set_mapping(struct policydb *pol,
                }
 
                k = 0;
-               while (p_in->perms && p_in->perms[k]) {
+               while (p_in->perms[k]) {
                        /* An empty permission string skips ahead */
                        if (!*p_in->perms[k]) {
                                k++;