dmaengine: shdma: (cosmetic) simplify a static function
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Thu, 5 Jul 2012 10:29:37 +0000 (12:29 +0200)
committerVinod Koul <vinod.koul@linux.intel.com>
Fri, 20 Jul 2012 05:53:44 +0000 (11:23 +0530)
dmae_find_slave() needs only the slave_id field from the slave object, no
need to pass the pointer to the object, pass the slave_id directly.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
drivers/dma/sh/shdma.c

index c393b354e2b36c53dbad852f5c6c3c340bd9f9e0..f06906f281acb4e25fe90ff467d890197e8b0a24 100644 (file)
@@ -304,18 +304,18 @@ static void sh_dmae_setup_xfer(struct shdma_chan *schan,
 }
 
 static const struct sh_dmae_slave_config *dmae_find_slave(
-       struct sh_dmae_chan *sh_chan, struct sh_dmae_slave *slave)
+       struct sh_dmae_chan *sh_chan, unsigned int slave_id)
 {
        struct sh_dmae_device *shdev = to_sh_dev(sh_chan);
        struct sh_dmae_pdata *pdata = shdev->pdata;
        const struct sh_dmae_slave_config *cfg;
        int i;
 
-       if (slave->shdma_slave.slave_id >= SH_DMA_SLAVE_NUMBER)
+       if (slave_id >= SH_DMA_SLAVE_NUMBER)
                return NULL;
 
        for (i = 0, cfg = pdata->slave; i < pdata->slave_num; i++, cfg++)
-               if (cfg->slave_id == slave->shdma_slave.slave_id)
+               if (cfg->slave_id == slave_id)
                        return cfg;
 
        return NULL;
@@ -328,7 +328,7 @@ static int sh_dmae_set_slave(struct shdma_chan *schan,
                                                    shdma_chan);
        struct sh_dmae_slave *slave = container_of(sslave, struct sh_dmae_slave,
                                                   shdma_slave);
-       const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, slave);
+       const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, sslave->slave_id);
        if (!cfg)
                return -ENODEV;