NFC: double unlock in nfc_llcp_recv_connect()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 16 Dec 2011 20:25:29 +0000 (23:25 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 19 Dec 2011 19:40:22 +0000 (14:40 -0500)
We unlock inside the if block on the other side of this if else
statement.  It could result in calling mutex_unlock() twice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/nfc/llcp/llcp.c

index 67756b23eac54f9dc932eb12393dda9cfa48a01e..f99d6b4658ed8477049f0275e698ed22daa18a87 100644 (file)
@@ -554,11 +554,9 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
                                goto enqueue;
                        }
                }
-
+               mutex_unlock(&local->socket_lock);
        }
 
-       mutex_unlock(&local->socket_lock);
-
        reason = LLCP_DM_NOBOUND;
        goto fail;