nfsd: do not clear rpc_resp in nfsd4_cb_done_sequence
authorBenny Halevy <bhalevy@panasas.com>
Tue, 23 Sep 2014 06:58:49 +0000 (08:58 +0200)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 26 Sep 2014 20:29:25 +0000 (16:29 -0400)
This is incorrect when a callback is has to be restarted, in which case
the XDR decoding of the second iteration will see a NULL cb argument.

[hch: updated description]
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4callback.c

index 795e218a2a98865e1c9088bcc37c057c0b8ef40f..fc07084e8226170dd193e78ecef5943572096421 100644 (file)
@@ -847,9 +847,6 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
                rpc_wake_up_next(&clp->cl_cb_waitq);
                dprintk("%s: freed slot, new seqid=%d\n", __func__,
                        clp->cl_cb_session->se_cb_seq_nr);
-
-               /* We're done looking into the sequence information */
-               task->tk_msg.rpc_resp = NULL;
        }
 }