tty: ipwireless: Fix potential NULL pointer dereference
authorYueHaibing <yuehaibing@huawei.com>
Wed, 30 Jan 2019 10:30:51 +0000 (18:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:13 +0000 (10:24 +0100)
[ Upstream commit 7dd50e205b3348dc7784efbdf85723551de64a25 ]

There is a potential NULL pointer dereference in case
alloc_ctrl_packet() fails and returns NULL.

Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/ipwireless/hardware.c

index df0204b6148fb03efd3a348b96345ad84db3285a..4417f75684221a09ac4209f817e77f2a970748f9 100644 (file)
@@ -1515,6 +1515,8 @@ static void ipw_send_setup_packet(struct ipw_hardware *hw)
                        sizeof(struct ipw_setup_get_version_query_packet),
                        ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP,
                        TL_SETUP_SIGNO_GET_VERSION_QRY);
+       if (!ver_packet)
+               return;
        ver_packet->header.length = sizeof(struct tl_setup_get_version_qry);
 
        /*