staging: comedi: dt2801: fix using uninitialized variable warnings
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 26 Sep 2013 17:29:20 +0000 (10:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Sep 2013 23:36:19 +0000 (16:36 -0700)
As pointed out by Fengguang Wu, the calls to dt2801_readdata() return the
data read thru a pointer (the address of a local variable) passed as a
parameter. If this local variable is not initialized it produces a warning
during the build of the form:

drivers/staging/comedi/drivers/dt2801.c: In function 'dt2801_ai_insn_read':
drivers/staging/comedi/drivers/dt2801.c:273:14: warning: 'hb' is used
      uninitialized in this function [-Wuninitialized]

Fix these warning by making sure the local variables are initialized.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt2801.c

index 1a2b0e4b1ea5c2d246a5e2e65186403c8c5d3bd3..811c8c59c01761f87ef8a9936cd3b648d8ea3751 100644 (file)
@@ -260,7 +260,8 @@ static int dt2801_readdata(struct comedi_device *dev, int *data)
 
 static int dt2801_readdata2(struct comedi_device *dev, int *data)
 {
-       int lb, hb;
+       int lb = 0;
+       int hb = 0;
        int ret;
 
        ret = dt2801_readdata(dev, &lb);
@@ -532,7 +533,7 @@ static int dt2801_dio_insn_bits(struct comedi_device *dev,
                                unsigned int *data)
 {
        int which = (s == &dev->subdevices[3]) ? 1 : 0;
-       unsigned int val;
+       unsigned int val = 0;
 
        if (comedi_dio_update_state(s, data)) {
                dt2801_writecmd(dev, DT_C_WRITE_DIG);