netconsole: do not release spin_lock when calling __netpoll_cleanup
authorAmerigo Wang <amwang@redhat.com>
Fri, 10 Aug 2012 01:24:39 +0000 (01:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Aug 2012 21:33:31 +0000 (14:33 -0700)
With the previous patch applied, __netpoll_cleanup() is non-block now,
so we don't need to release the spin_lock before calling it.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netconsole.c

index f9347ea3d381e113d20c6a13ec32f0f51c5fc04c..f0ad56c13933e1e8de4aec326d21295f832c94cc 100644 (file)
@@ -640,12 +640,7 @@ static int netconsole_netdev_event(struct notifier_block *this,
                                 * rtnl_lock already held
                                 */
                                if (nt->np.dev) {
-                                       spin_unlock_irqrestore(
-                                                             &target_list_lock,
-                                                             flags);
                                        __netpoll_cleanup(&nt->np);
-                                       spin_lock_irqsave(&target_list_lock,
-                                                         flags);
                                        dev_put(nt->np.dev);
                                        nt->np.dev = NULL;
                                        netconsole_target_put(nt);