irqchip/gic-v3-its: Specialise flush_dcache operation
authorVladimir Murzin <vladimir.murzin@arm.com>
Wed, 2 Nov 2016 11:54:05 +0000 (11:54 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 29 Nov 2016 09:14:48 +0000 (09:14 +0000)
It'd be better to switch to CMA... but before that done redirect
flush_dcache operation, so 32-bit implementation could be wired
latter.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
arch/arm64/include/asm/arch_gicv3.h
drivers/irqchip/irq-gic-v3-its.c

index 0313670a3e3fb53ce358a14ff25367386d0aa7a7..546f92b32b62524cfca84cda8d85b1c6a17ac9ca 100644 (file)
@@ -79,6 +79,7 @@
 
 #include <linux/stringify.h>
 #include <asm/barrier.h>
+#include <asm/cacheflush.h>
 
 #define read_gicreg                    read_sysreg_s
 #define write_gicreg                   write_sysreg_s
@@ -171,5 +172,7 @@ static inline void gic_write_bpr1(u32 val)
 #define gic_read_typer(c)              readq_relaxed(c)
 #define gic_write_irouter(v, c)                writeq_relaxed(v, c)
 
+#define gic_flush_dcache_to_poc(a,l)   __flush_dcache_area((a), (l))
+
 #endif /* __ASSEMBLY__ */
 #endif /* __ASM_ARCH_GICV3_H */
index 312dd55dfaae8ce40eb38b4804dffcfbe467f2ae..b2a6e7b0bf9af7b56b226f940d2ccd69608f4828 100644 (file)
@@ -37,7 +37,6 @@
 #include <linux/irqchip.h>
 #include <linux/irqchip/arm-gic-v3.h>
 
-#include <asm/cacheflush.h>
 #include <asm/cputype.h>
 #include <asm/exception.h>
 
@@ -433,7 +432,7 @@ static void its_flush_cmd(struct its_node *its, struct its_cmd_block *cmd)
         * the ITS.
         */
        if (its->flags & ITS_FLAGS_CMDQ_NEEDS_FLUSHING)
-               __flush_dcache_area(cmd, sizeof(*cmd));
+               gic_flush_dcache_to_poc(cmd, sizeof(*cmd));
        else
                dsb(ishst);
 }
@@ -602,7 +601,7 @@ static void lpi_set_config(struct irq_data *d, bool enable)
         * Humpf...
         */
        if (gic_rdists->flags & RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING)
-               __flush_dcache_area(cfg, sizeof(*cfg));
+               gic_flush_dcache_to_poc(cfg, sizeof(*cfg));
        else
                dsb(ishst);
        its_send_inv(its_dev, id);
@@ -817,7 +816,7 @@ static int __init its_alloc_lpi_tables(void)
               LPI_PROPBASE_SZ);
 
        /* Make sure the GIC will observe the written configuration */
-       __flush_dcache_area(page_address(gic_rdists->prop_page), LPI_PROPBASE_SZ);
+       gic_flush_dcache_to_poc(page_address(gic_rdists->prop_page), LPI_PROPBASE_SZ);
 
        return 0;
 }
@@ -910,7 +909,7 @@ retry_baser:
                shr = tmp & GITS_BASER_SHAREABILITY_MASK;
                if (!shr) {
                        cache = GITS_BASER_nC;
-                       __flush_dcache_area(base, PAGE_ORDER_TO_SIZE(order));
+                       gic_flush_dcache_to_poc(base, PAGE_ORDER_TO_SIZE(order));
                }
                goto retry_baser;
        }
@@ -1102,7 +1101,7 @@ static void its_cpu_init_lpis(void)
                }
 
                /* Make sure the GIC will observe the zero-ed page */
-               __flush_dcache_area(page_address(pend_page), LPI_PENDBASE_SZ);
+               gic_flush_dcache_to_poc(page_address(pend_page), LPI_PENDBASE_SZ);
 
                paddr = page_to_phys(pend_page);
                pr_info("CPU%d: using LPI pending table @%pa\n",
@@ -1287,13 +1286,13 @@ static bool its_alloc_device_table(struct its_node *its, u32 dev_id)
 
                /* Flush Lvl2 table to PoC if hw doesn't support coherency */
                if (!(baser->val & GITS_BASER_SHAREABILITY_MASK))
-                       __flush_dcache_area(page_address(page), baser->psz);
+                       gic_flush_dcache_to_poc(page_address(page), baser->psz);
 
                table[idx] = cpu_to_le64(page_to_phys(page) | GITS_BASER_VALID);
 
                /* Flush Lvl1 entry to PoC if hw doesn't support coherency */
                if (!(baser->val & GITS_BASER_SHAREABILITY_MASK))
-                       __flush_dcache_area(table + idx, GITS_LVL1_ENTRY_SIZE);
+                       gic_flush_dcache_to_poc(table + idx, GITS_LVL1_ENTRY_SIZE);
 
                /* Ensure updated table contents are visible to ITS hardware */
                dsb(sy);
@@ -1340,7 +1339,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
                return NULL;
        }
 
-       __flush_dcache_area(itt, sz);
+       gic_flush_dcache_to_poc(itt, sz);
 
        dev->its = its;
        dev->itt = itt;