usb: gadget: renesas_usbhs: remove usbhs_sys_usb_ctrl()

usbhs_sys_usb_ctrl() can collect into usbhs_sys_host/function_ctrl().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 38249da8e7b21c5557d4b092d749c2e96fb0b7dd..ce54abfde006d22e19a672ec049c209f97938bed 100644 (file)
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -100,15 +100,10 @@ void usbhs_sys_clock_ctrl(struct usbhs_priv *priv, int enable)
        usbhs_bset(priv, SYSCFG, SCKE, enable ? SCKE : 0);
 }
 
-void usbhs_sys_usb_ctrl(struct usbhs_priv *priv, int enable)
-{
-       usbhs_bset(priv, SYSCFG, USBE, enable ? USBE : 0);
-}
-
 void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable)
 {
-       u16 mask = DCFM | DRPD | DPRPU | HSE;
-       u16 val  = DCFM | DRPD | HSE;
+       u16 mask = DCFM | DRPD | DPRPU | HSE | USBE;
+       u16 val  = DCFM | DRPD | HSE | USBE;
        int has_otg = usbhs_get_dparam(priv, has_otg);
 
        if (has_otg)
@@ -125,8 +120,8 @@ void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable)
 
 void usbhs_sys_function_ctrl(struct usbhs_priv *priv, int enable)
 {
-       u16 mask = DCFM | DRPD | DPRPU | HSE;
-       u16 val  = DPRPU | HSE;
+       u16 mask = DCFM | DRPD | DPRPU | HSE | USBE;
+       u16 val  = DPRPU | HSE | USBE;
 
        /*
         * if enable

diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index 30d1887fda998ab57fc786b71271b5b30861c95b..46c9fd2f30ed87baf09782cb31fd5825964b3192 100644 (file)
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -284,7 +284,6 @@ int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev);
  * sysconfig
  */
 void usbhs_sys_clock_ctrl(struct usbhs_priv *priv, int enable);
-void usbhs_sys_usb_ctrl(struct usbhs_priv *priv, int enable);
 void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable);
 void usbhs_sys_function_ctrl(struct usbhs_priv *priv, int enable);
 

diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
index f23839ddd62ccdec40e6ff4bade46d3f1fec2aa6..8fb9056ff48d724ee2502db7a65e194776c2ff2d 100644 (file)
--- a/drivers/usb/renesas_usbhs/mod_gadget.c
+++ b/drivers/usb/renesas_usbhs/mod_gadget.c
@@ -682,7 +682,6 @@ static int usbhsg_try_start(struct usbhs_priv *priv, u32 status)
         * - usb module
         */
        usbhs_sys_function_ctrl(priv, 1);
-       usbhs_sys_usb_ctrl(priv, 1);
 
        /*
         * enable irq callback
@@ -731,7 +730,6 @@ static int usbhsg_try_stop(struct usbhs_priv *priv, u32 status)
 
        /* disable sys */
        usbhs_sys_function_ctrl(priv, 0);
-       usbhs_sys_usb_ctrl(priv, 0);
 
        usbhsg_pipe_disable(dcp);
 

diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
index 366a8a79fd5630cd25d964d386fb0a8b7eded11e..2656d5989e68babee700361ec98dba236e40ce6c 100644 (file)
--- a/drivers/usb/renesas_usbhs/mod_host.c
+++ b/drivers/usb/renesas_usbhs/mod_host.c
@@ -1206,7 +1206,6 @@ static int usbhsh_start(struct usbhs_priv *priv)
         * - usb module
         */
        usbhs_sys_host_ctrl(priv, 1);
-       usbhs_sys_usb_ctrl(priv, 1);
 
        /*
         * enable irq callback
@@ -1242,7 +1241,6 @@ static int usbhsh_stop(struct usbhs_priv *priv)
 
        /* disable sys */
        usbhs_sys_host_ctrl(priv, 0);
-       usbhs_sys_usb_ctrl(priv, 0);
 
        dev_dbg(dev, "quit host\n");