[media] saa7164: Avoid spurious error after firmware starts
authorSteven Toth <stoth@kernellabs.com>
Sat, 31 Jul 2010 19:03:55 +0000 (16:03 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Oct 2010 09:55:03 +0000 (07:55 -0200)
Signed-off-by: Steven Toth <stoth@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/saa7164/saa7164-core.c

index 8879517d974a52fec133bf3e1b71fcd6c67a21af..b1efbeae85984c726ed8092054291ab51481559f 100644 (file)
@@ -163,14 +163,21 @@ static void saa7164_ts_verifier(struct saa7164_buffer *buf)
 
        }
 
-       if (port->v_cc_errors)
+       /* Only report errors if we've been through this function atleast
+        * once already and the cached cc values are primed. First time through
+        * always generates errors.
+        */
+       if (port->v_cc_errors && (port->done_first_interrupt > 1))
                printk(KERN_ERR "video pid cc, %d errors\n", port->v_cc_errors);
 
-       if (port->a_cc_errors)
+       if (port->a_cc_errors && (port->done_first_interrupt > 1))
                printk(KERN_ERR "audio pid cc, %d errors\n", port->a_cc_errors);
 
-       if (port->sync_errors)
+       if (port->sync_errors && (port->done_first_interrupt > 1))
                printk(KERN_ERR "sync_errors = %d\n", port->sync_errors);
+
+       if (port->done_first_interrupt == 1)
+               port->done_first_interrupt++;
 }
 
 static void saa7164_histogram_reset(struct saa7164_histogram *hg, char *name)