staging: ks7010: use kernel helper to print buffer
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 31 May 2016 10:56:20 +0000 (12:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jun 2016 05:42:53 +0000 (22:42 -0700)
No need for an open coded one.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/Makefile
drivers/staging/ks7010/ks7010_sdio.c
drivers/staging/ks7010/ks_debug.c [deleted file]
drivers/staging/ks7010/ks_debug.h

index 32b0efc7bd00e89da78ce5ee9fb3926377dc9f37..f6a2cc8fd0276daac978ca4ad9d0509af5fcd483 100644 (file)
@@ -1,5 +1,5 @@
 obj-$(CONFIG_KS7010) += ks7010.o
 
 ccflags-y           += -DKS_WLAN_DEBUG=0
-ks7010-y            := michael_mic.o ks_hostif.o ks_wlan_net.o ks_debug.o \
+ks7010-y            := michael_mic.o ks_hostif.o ks_wlan_net.o \
                                        ks7010_sdio.o ks7010_config.o
index 5b78522fad1ec1dd784a09991d44e734d647ebad..1a1a43ff306aae73b713d9e4ee94935f63190ac7 100644 (file)
@@ -441,10 +441,11 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 
        /* length check */
        if(size > 2046 || size == 0){
-
-               DPRINTK(5,"-INVAILED DATA dump\n");
-               print_buffer(&rx_buffer->data[0],32);
-
+#ifdef KS_WLAN_DEBUG
+               if (KS_WLAN_DEBUG > 5)
+                       print_hex_dump_bytes("INVALID DATA dump: ", DUMP_PREFIX_OFFSET,
+                                            rx_buffer->data, 32);
+#endif
                /* rx_status update */
                read_status = READ_STATUS_IDLE;
                retval = ks7010_sdio_write(priv, READ_STATUS, &read_status, sizeof(read_status));
diff --git a/drivers/staging/ks7010/ks_debug.c b/drivers/staging/ks7010/ks_debug.c
deleted file mode 100644 (file)
index 009f5f6..0000000
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- *   Driver for KeyStream 11b/g wireless LAN cards.
- *   
- *   ks_debug.c
- *   $Id: ks_debug.c 991 2009-09-14 01:38:58Z sekine $
- *
- *   Copyright (C) 2005-2008 KeyStream Corp.
- *   Copyright (C) 2009 Renesas Technology Corp.
- *
- *   This program is free software; you can redistribute it and/or modify
- *   it undr the terms of the GNU General Public License version 2 as
- *   published by the Free Sotware Foundation.
- */
-#include "ks_wlan.h"
-#include "ks_debug.h"
-
-void print_buffer(unsigned char *p, int length)
-{
-#ifdef KS_WLAN_DEBUG
-        int i;
-#define HEX_OFFSET "\
-           +0 +1 +2 +3 +4 +5 +6 +7 +8 +9 +A +B +C +D +E +F"
-        printk(HEX_OFFSET);
-        for (i=0; i<length; i++) {
-                if (i % 16 == 0) printk("\n%04X-%04X:", i, i+15);
-                printk(" %02X", *(p+i));
-        }
-        printk("\n");
-#endif
-}
index 2fd5d8484b7f045c1f4e1e4011315ba03e12759e..adad5f927dfda95fcfcab8d40eaa7fdc3c3af8a9 100644 (file)
@@ -25,6 +25,4 @@
 #define DPRINTK(n, fmt, args...)
 #endif
 
-extern void print_buffer(unsigned char *p, int size);
-
 #endif /* _KS_DEBUG_H */