dmaengine: dw: platform: power on device on shutdown
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 4 Dec 2015 21:49:23 +0000 (23:49 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 7 Jan 2016 13:11:53 +0000 (14:11 +0100)
We have to call dw_dma_disable() to stop any ongoing transfer. On some
platforms we can't do that since DMA device is powered off. Moreover we have no
possibility at that point to check if the platform is affected or not. That's
why we call pm_runtime_get_sync() / pm_runtime_put() unconditionally. On the
other hand we can't use pm_runtime_suspended() because runtime PM framework is
not fully used by the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/dma/dw/platform.c

index 68a4815750b514bcd94a312885607a83db7d99cf..d0734e912b795dca4df8839280690640d44e1f3e 100644 (file)
@@ -239,7 +239,19 @@ static void dw_shutdown(struct platform_device *pdev)
 {
        struct dw_dma_chip *chip = platform_get_drvdata(pdev);
 
+       /*
+        * We have to call dw_dma_disable() to stop any ongoing transfer. On
+        * some platforms we can't do that since DMA device is powered off.
+        * Moreover we have no possibility to check if the platform is affected
+        * or not. That's why we call pm_runtime_get_sync() / pm_runtime_put()
+        * unconditionally. On the other hand we can't use
+        * pm_runtime_suspended() because runtime PM framework is not fully
+        * used by the driver.
+        */
+       pm_runtime_get_sync(chip->dev);
        dw_dma_disable(chip);
+       pm_runtime_put_sync_suspend(chip->dev);
+
        clk_disable_unprepare(chip->clk);
 }