[NETFILTER]: arp_tables: fix NULL pointer dereference
authorPatrick McHardy <kaber@trash.net>
Mon, 13 Mar 2006 04:40:43 +0000 (20:40 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Mar 2006 04:40:43 +0000 (20:40 -0800)
The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL)
is true.

Coverity #190

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/arp_tables.c

index dd1048be8a0115b4cd08591fbd3b29b19e9bda36..7d7ab94a7a2e73abef1f804174aed3c94abf86ac 100644 (file)
@@ -771,7 +771,7 @@ static int get_entries(const struct arpt_get_entries *entries,
        struct arpt_table *t;
 
        t = xt_find_table_lock(NF_ARP, entries->name);
-       if (t || !IS_ERR(t)) {
+       if (t && !IS_ERR(t)) {
                struct xt_table_info *private = t->private;
                duprintf("t->private->number = %u\n",
                         private->number);