backlight: cr_bllcd: use pr_err()/pr_info() instead of printk()
authorJingoo Han <jg1.han@samsung.com>
Tue, 29 May 2012 22:07:17 +0000 (15:07 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 29 May 2012 23:22:29 +0000 (16:22 -0700)
Use pr_err()/pr_info() instead of printk() to allow dynamic debugging.
The pr_fmt prefix for pr_ macros is used.  Also fix checkpatch warnings as
below:

WARNING: printk() should include KERN_ facility level
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...

[akpm@linux-foundation.org: use KBUILD_MODNAME, per Joe]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/backlight/cr_bllcd.c

index 22489eb5f3e0beb525c3965df1d1186c1ee914ca..37bae801e23bfa5e9c8085ef6bae47648730ac14 100644 (file)
@@ -27,6 +27,8 @@
  *   Alan Hourihane <alanh-at-tungstengraphics-dot-com>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
@@ -180,14 +182,13 @@ static int cr_backlight_probe(struct platform_device *pdev)
        lpc_dev = pci_get_device(PCI_VENDOR_ID_INTEL,
                                        CRVML_DEVICE_LPC, NULL);
        if (!lpc_dev) {
-               printk("INTEL CARILLO RANCH LPC not found.\n");
+               pr_err("INTEL CARILLO RANCH LPC not found.\n");
                return -ENODEV;
        }
 
        pci_read_config_byte(lpc_dev, CRVML_REG_GPIOEN, &dev_en);
        if (!(dev_en & CRVML_GPIOEN_BIT)) {
-               printk(KERN_ERR
-                      "Carillo Ranch GPIO device was not enabled.\n");
+               pr_err("Carillo Ranch GPIO device was not enabled.\n");
                pci_dev_put(lpc_dev);
                return -ENODEV;
        }
@@ -270,7 +271,7 @@ static int __init cr_backlight_init(void)
                return PTR_ERR(crp);
        }
 
-       printk("Carillo Ranch Backlight Driver Initialized.\n");
+       pr_info("Carillo Ranch Backlight Driver Initialized.\n");
 
        return 0;
 }