ps3disk: Remove superfluous cast
authorGeert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Fri, 25 Apr 2008 10:46:20 +0000 (12:46 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Tue, 29 Apr 2008 07:50:34 +0000 (09:50 +0200)
As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
cast is not needed.

Reuse in another (possibly 32-bit) driver is protected by the safety net called
`compiler warning' (with the cast, it may silently truncate to 32-bit).
If sector_t ever changes, we will get a compiler warning as well (with the
cast, we won't).

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
drivers/block/ps3disk.c

index 7483f947f0e995d435585508daaa8583be926b3a..78e9ea73a31a01d1f86c0766629caa21dd1846aa 100644 (file)
@@ -102,8 +102,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
                dev_dbg(&dev->sbd.core,
                        "%s:%u: bio %u: %u segs %u sectors from %lu\n",
                        __func__, __LINE__, i, bio_segments(iter.bio),
-                       bio_sectors(iter.bio),
-                       (unsigned long)iter.bio->bi_sector);
+                       bio_sectors(iter.bio), iter.bio->bi_sector);
 
                size = bvec->bv_len;
                buf = bvec_kmap_irq(bvec, &flags);