bnx2x: no error when RSS configuration fails

It's possible for VMs with older versions of bnx2x to run over a hypervisor
with latest driver. If a VF in such a VM does not support RSS configuration,
the PF driver in the hypervisor will print an error message to system logs.

This changes the error message into a debug message, as this is very likely
a false alarm for an older VF (i.e., VF manages to work properly; PF simply
cannot configure the additional queues for it).

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
index efa8a151d78907d4b17d5f5dd07eaed9b1f2c02c..82a6b6b2406dc103345050080d8366dc0fd5f2d2 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
@@ -800,14 +800,18 @@ int bnx2x_vfpf_config_rss(struct bnx2x *bp,
        }
 
        if (resp->hdr.status != PFVF_STATUS_SUCCESS) {
-               BNX2X_ERR("failed to send rss message to PF over Vf PF channel %d\n",
-                         resp->hdr.status);
-               rc = -EINVAL;
+               /* Since older drivers don't support this feature (and VF has
+                * no way of knowing other than failing this), don't propagate
+                * an error in this case.
+                */
+               DP(BNX2X_MSG_IOV,
+                  "Failed to send rss message to PF over VF-PF channel [%d]\n",
+                  resp->hdr.status);
        }
 out:
        bnx2x_vfpf_finalize(bp, &req->first_tlv);
 
-       return 0;
+       return rc;
 }
 
 int bnx2x_vfpf_set_mcast(struct net_device *dev)