drm/i915: Rework drop caches for checkpatch

With an upcoming change to bind, to make checkpatch happy and keep the
code clean, we need to rework this code a bit.

This should have no functional impact.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
[danvet: Add the newline Chris requested.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index eed2f4ca9a766ffd68f0e34fc8b3d4333f8e6e1e..04debcedac2d03fdc323003d2c6b16cd096c98a9 100644 (file)
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1784,12 +1784,14 @@ i915_drop_caches_set(void *data, u64 val)
 
        if (val & DROP_BOUND) {
                list_for_each_entry_safe(obj, next, &vm->inactive_list,
-                                        mm_list)
-                       if (obj->pin_count == 0) {
-                               ret = i915_gem_object_unbind(obj);
-                               if (ret)
-                                       goto unlock;
-                       }
+                                        mm_list) {
+                       if (obj->pin_count)
+                               continue;
+
+                       ret = i915_gem_object_unbind(obj);
+                       if (ret)
+                               goto unlock;
+               }
        }
 
        if (val & DROP_UNBOUND) {