IB/mthca: Fix error return code in __mthca_init_one()
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 29 Sep 2018 03:55:16 +0000 (03:55 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Nov 2019 08:53:27 +0000 (09:53 +0100)
[ Upstream commit 39f2495618c5e980d2873ea3f2d1877dd253e07a ]

Fix to return a negative error code from the mthca_cmd_init() error
handling case instead of 0, as done elsewhere in this function.

Fixes: 80fd8238734c ("[PATCH] IB/mthca: Encapsulate command interface init")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/mthca/mthca_main.c

index ded76c101dde3d74a36c85fb9a71f90050969b55..834b06aacc2bfcb8f4003c232007a991dba29f14 100644 (file)
@@ -989,7 +989,8 @@ static int __mthca_init_one(struct pci_dev *pdev, int hca_type)
                goto err_free_dev;
        }
 
-       if (mthca_cmd_init(mdev)) {
+       err = mthca_cmd_init(mdev);
+       if (err) {
                mthca_err(mdev, "Failed to init command interface, aborting.\n");
                goto err_free_dev;
        }