aoe: fix use after free in aoedev_by_aoeaddr()

We should return NULL on failure instead of returning a freed pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ed Cashin <ecashin@coraid.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index e66ccbf41a50b3013012ec7fd64c64e13ac8c051..98f2965778b9ce18a4a58aaf91544d5b35a3d134 100644 (file)
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc)
        d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC);
        if (!d->targets) {
                kfree(d);
+               d = NULL;
                goto out;
        }
        d->ntargets = NTARGETS;