usb: dwc3: prevent setting PRTCAP to OTG from debugfs
authorRoger Quadros <rogerq@ti.com>
Tue, 27 Feb 2018 10:54:37 +0000 (12:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Apr 2018 07:36:26 +0000 (09:36 +0200)
commit daaecc6541d014dca073473ec8a4120c0babbeb4 upstream.

We don't support PRTCAP == OTG yet, so prevent user from
setting it via debugfs.

Fixes: 41ce1456e1db ("usb: dwc3: core: make dwc3_set_mode() work properly")
Cc: <stable@vger.kernel.org> # v4.12+
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/core.c

index 3219d8157f5bfe4b28643559fcf10665d7bd97c4..c3f3f1a89b0f098e443079ec9480981d94d6cf73 100644 (file)
@@ -128,6 +128,9 @@ static void __dwc3_set_mode(struct work_struct *work)
        if (dwc->dr_mode != USB_DR_MODE_OTG)
                return;
 
+       if (dwc->desired_dr_role == DWC3_GCTL_PRTCAP_OTG)
+               return;
+
        switch (dwc->current_dr_role) {
        case DWC3_GCTL_PRTCAP_HOST:
                dwc3_host_exit(dwc);