powerpc/BSR: fix device_create() return value check
authorJani Nikula <ext-jani.1.nikula@nokia.com>
Thu, 11 Mar 2010 16:15:53 +0000 (18:15 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 15 Mar 2010 14:31:04 +0000 (15:31 +0100)
Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Acked-by: Sonny Rao <sonnyrao@us.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/char/bsr.c

index c02db01f736ea46bc536190910a2f4a9e336bfbb..3b31f744b7af8c91dbe685929a46fb9155a4f3f6 100644 (file)
@@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn)
 
                cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
                                                cur, cur->bsr_name);
-               if (!cur->bsr_device) {
+               if (IS_ERR(cur->bsr_device)) {
                        printk(KERN_ERR "device_create failed for %s\n",
                               cur->bsr_name);
                        cdev_del(&cur->bsr_cdev);