staging: comedi: usbduxsigma: fixing rounding error in the range struct
authorBernd Porr <mail@berndporr.me.uk>
Tue, 1 Jul 2014 21:14:42 +0000 (22:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Jul 2014 23:27:29 +0000 (16:27 -0700)
The AD converter on the usbsigma turns vref (2.5V/2) into the
binary value 0x780000. However the full scale range goes up to
0x800000 so that vref/2 needs to be upscaled by 0x800000/0x780000
which is 1.06bar. In the driver it's been 1.06 without the infinite
6666. I've put the fraction in the code so that the compiler can
calculate the most precise scaling value by itself.

Signed-off-by: Bernd Porr <mail@berndporr.me.uk>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbduxsigma.c

index ccc3ef7ba55c479f47d901bf7e3f4520e3552512..e869af4784c60796e6c4255f19b0062b3eaae1ae 100644 (file)
 
 static const struct comedi_lrange usbduxsigma_ai_range = {
        1, {
-               BIP_RANGE(2.65 / 2.0)
+               BIP_RANGE(2.5 * 0x800000 / 0x780000 / 2.0)
        }
 };