projects / GitHub / WoltLab / WCF.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 75611e7)
Some external links in the admin panel did not open in a new window
authorMarcel Werk <burntime@woltlab.com>
Wed, 4 Aug 2021 13:27:50 +0000 (15:27 +0200)
committerMarcel Werk <burntime@woltlab.com>
Wed, 4 Aug 2021 13:27:50 +0000 (15:27 +0200)
wcfsetup/install/files/acp/templates/index.tpl patch | blob | blame | history
wcfsetup/install/files/acp/templates/package.tpl patch | blob | blame | history
wcfsetup/install/files/acp/templates/packageList.tpl patch | blob | blame | history
wcfsetup/install/files/acp/templates/packageSearchResultListItems.tpl patch | blob | blame | history
wcfsetup/install/files/acp/templates/pageHeaderUser.tpl patch | blob | blame | history
wcfsetup/install/files/acp/templates/pageMenuMobile.tpl patch | blob | blame | history

diff --git a/wcfsetup/install/files/acp/templates/index.tpl b/wcfsetup/install/files/acp/templates/index.tpl
index 6424d0d7465707eecb9e647f95215b25fbf6a080..5fc5ab54bd93a120bfc389808087a87c82107eeb 100644 (file)
--- a/wcfsetup/install/files/acp/templates/index.tpl
+++ b/wcfsetup/install/files/acp/templates/index.tpl
@@ -184,7 +184,7 @@
                <section class="section">
                        <dl>
                                <dt>{lang}wcf.acp.index.credits.developedBy{/lang}</dt>
-                               <dd><a href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>WoltLab&reg; GmbH</a></dd>
+                               <dd><a href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>WoltLab&reg; GmbH</a></dd>
                        </dl>
                        
                        <dl>
@@ -226,7 +226,7 @@
                                                <li>Andrea Berg</li>
                                                <li>Thorsten Buitkamp</li>
                                                <li>
-                                                       <a href="https://github.com/WoltLab/WCF/contributors" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.credits.contributor.more{/lang}</a>
+                                                       <a href="https://github.com/WoltLab/WCF/contributors" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.credits.contributor.more{/lang}</a>
                                                </li>
                                        </ul>
                                </dd>
diff --git a/wcfsetup/install/files/acp/templates/package.tpl b/wcfsetup/install/files/acp/templates/package.tpl
index 4435fc571ed1c2b80b2d1b7fa5bfcbcda3bfd41f..4c8b8a40f7d08d08231ab29e9b2fda0020df8c9d 100644 (file)
--- a/wcfsetup/install/files/acp/templates/package.tpl
+++ b/wcfsetup/install/files/acp/templates/package.tpl
@@ -68,17 +68,17 @@
                        {if $package->packageURL != ''}
                                <dl>
                                        <dt>{lang}wcf.acp.package.url{/lang}</dt>
-                                       <dd><a href="{$package->packageURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{$package->packageURL}</a></dd>
+                                       <dd><a href="{$package->packageURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$package->packageURL}</a></dd>
                                </dl>
                        {/if}
                        <dl>
                                <dt>{lang}wcf.acp.package.author{/lang}</dt>
-                               <dd>{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{$package->author}</a>{else}{$package->author}{/if}</dd>
+                               <dd>{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$package->author}</a>{else}{$package->author}{/if}</dd>
                        </dl>
                        {if $pluginStoreFileID}
                                <dl>
                                        <dt>{lang}wcf.acp.pluginStore.file{/lang}</dt>
-                                       <dd><a href="https://pluginstore.woltlab.com/file/{$pluginStoreFileID}/" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.pluginStore.file.link{/lang}</a></dd>
+                                       <dd><a href="https://pluginstore.woltlab.com/file/{$pluginStoreFileID}/" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.pluginStore.file.link{/lang}</a></dd>
                                </dl>
                        {/if}
                        {if $package->packageID != 1}
@@ -143,7 +143,7 @@
                                                                                </td>
                                                                                <td class="columnID">{@$requiredPackage->packageID}</td>
                                                                                <td class="columnTitle" title="{$requiredPackage->getDescription()}"><a href="{link controller='Package' id=$requiredPackage->packageID}{/link}">{$requiredPackage}</a></td>
-                                                                               <td class="columnText">{if $requiredPackage->authorURL}<a href="{$requiredPackage->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{$requiredPackage->author}</a>{else}{$requiredPackage->author}{/if}</td>
+                                                                               <td class="columnText">{if $requiredPackage->authorURL}<a href="{$requiredPackage->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$requiredPackage->author}</a>{else}{$requiredPackage->author}{/if}</td>
                                                                                <td class="columnText">{$requiredPackage->packageVersion}</td>
                                                                                <td class="columnDate">{@$requiredPackage->packageDate|date}</td>
                                                                                
@@ -184,7 +184,7 @@
                                                                                </td>
                                                                                <td class="columnID">{@$dependentPackage->packageID}</td>
                                                                                <td class="columnTitle" title="{$dependentPackage->getDescription()}"><a href="{link controller='Package' id=$dependentPackage->packageID}{/link}">{$dependentPackage}</a></td>
-                                                                               <td class="columnText">{if $dependentPackage->authorURL}<a href="{$dependentPackage->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{$dependentPackage->author}</a>{else}{$dependentPackage->author}{/if}</td>
+                                                                               <td class="columnText">{if $dependentPackage->authorURL}<a href="{$dependentPackage->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$dependentPackage->author}</a>{else}{$dependentPackage->author}{/if}</td>
                                                                                <td class="columnText">{$dependentPackage->packageVersion}</td>
                                                                                <td class="columnDate">{@$dependentPackage->packageDate|date}</td>
                                                                                
diff --git a/wcfsetup/install/files/acp/templates/packageList.tpl b/wcfsetup/install/files/acp/templates/packageList.tpl
index 7c7feab3bdac22feb1b0248ce568ca9478474e33..2fbce10d8d7e645411cf510b86cbfbad0bce5317 100644 (file)
--- a/wcfsetup/install/files/acp/templates/packageList.tpl
+++ b/wcfsetup/install/files/acp/templates/packageList.tpl
@@ -119,7 +119,7 @@
                                                                ></span>
                                                        {/if}
                                                </td>
-                                               <td class="columnText">{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{$package->author}</a>{else}{$package->author}{/if}</td>
+                                               <td class="columnText">{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$package->author}</a>{else}{$package->author}{/if}</td>
                                                <td class="columnText">{$package->packageVersion}</td>
                                                <td class="columnDate">{@$package->updateDate|time}</td>
                                                
diff --git a/wcfsetup/install/files/acp/templates/packageSearchResultListItems.tpl b/wcfsetup/install/files/acp/templates/packageSearchResultListItems.tpl
index 3059f48cdfaf836a93801255092d0592a5aecaaa..0b1980d07eb61f182a5d21f36deedbc81d42e2fb 100644 (file)
--- a/wcfsetup/install/files/acp/templates/packageSearchResultListItems.tpl
+++ b/wcfsetup/install/files/acp/templates/packageSearchResultListItems.tpl
@@ -8,11 +8,11 @@
                        <div class="packageSearchDescription small">{$package->packageDescription}</div>
                        <span class="packageSearchPackage small">{$package->package}</span>
                        {if $package->pluginStoreFileID}
-                               <span class="packageSearchPluginStorePage separatorLeft small"><a href="https://pluginstore.woltlab.com/file/{@$package->pluginStoreFileID}/" class="externalURL jsTooltip" title="{lang}wcf.acp.pluginStore.file.link{/lang}">{lang}wcf.acp.pluginStore.file{/lang}</a></span>
+                               <span class="packageSearchPluginStorePage separatorLeft small"><a href="https://pluginstore.woltlab.com/file/{@$package->pluginStoreFileID}/" class="externalURL jsTooltip" title="{lang}wcf.acp.pluginStore.file.link{/lang}"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.pluginStore.file{/lang}</a></span>
                        {/if}
                </td>
-               <td class="columnText small packageSearchAuthor{if $package->getUpdateServer()->isWoltLabUpdateServer()} packageSearchAuthorWoltlab{/if}" title="{$package->author}">{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL">{$package->author|truncate:30}</a>{else}{$package->author|truncate:30}{/if}</td>
-               <td class="columnText small packageSearchLicense" title="{$package->getAccessibleVersion()->license}">{if $package->getAccessibleVersion()->licenseURL}<a href="{$package->getAccessibleVersion()->licenseURL}" class="externalURL">{$package->getAccessibleVersion()->license|truncate:30}</a>{else}{$package->getAccessibleVersion()->license|truncate:30}{/if}</td>
+               <td class="columnText small packageSearchAuthor{if $package->getUpdateServer()->isWoltLabUpdateServer()} packageSearchAuthorWoltlab{/if}" title="{$package->author}">{if $package->authorURL}<a href="{$package->authorURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$package->author|truncate:30}</a>{else}{$package->author|truncate:30}{/if}</td>
+               <td class="columnText small packageSearchLicense" title="{$package->getAccessibleVersion()->license}">{if $package->getAccessibleVersion()->licenseURL}<a href="{$package->getAccessibleVersion()->licenseURL}" class="externalURL"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{$package->getAccessibleVersion()->license|truncate:30}</a>{else}{$package->getAccessibleVersion()->license|truncate:30}{/if}</td>
                <td class="columnDate packageSearchDate">{@$package->getAccessibleVersion()->packageDate|time}</td>
        </tr>
 {/foreach}
diff --git a/wcfsetup/install/files/acp/templates/pageHeaderUser.tpl b/wcfsetup/install/files/acp/templates/pageHeaderUser.tpl
index 234c05b93737a5cee8404c6a6fc13592e4ab2b5d..9b6ab8552484866d2b00689aff6becd934e18330 100644 (file)
--- a/wcfsetup/install/files/acp/templates/pageHeaderUser.tpl
+++ b/wcfsetup/install/files/acp/templates/pageHeaderUser.tpl
@@ -38,11 +38,11 @@
                                <a href="#" class="dropdownToggle jsTooltip" title="WoltLab&reg;"><span class="icon icon32 fa-info"></span></a>
                                
                                <ul class="dropdownMenu" data-dropdown-alignment-horizontal="right">
-                                       <li><a class="externalURL" href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.website{/lang}</a></li>
-                                       <li><a class="externalURL" href="https://manual.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de{else}en{/if}/"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.manual{/lang}</a></li>
-                                       <li><a class="externalURL" href="https://community.woltlab.com"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.forums{/lang}</a></li>
-                                       <li><a class="externalURL" href="https://community.woltlab.com/ticket-add/"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.tickets{/lang}</a></li>
-                                       <li><a class="externalURL" href="https://pluginstore.woltlab.com"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.pluginStore{/lang}</a></li>
+                                       <li><a class="externalURL" href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.website{/lang}</a></li>
+                                       <li><a class="externalURL" href="https://manual.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de{else}en{/if}/"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.manual{/lang}</a></li>
+                                       <li><a class="externalURL" href="https://community.woltlab.com"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.forums{/lang}</a></li>
+                                       <li><a class="externalURL" href="https://community.woltlab.com/ticket-add/"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.tickets{/lang}</a></li>
+                                       <li><a class="externalURL" href="https://pluginstore.woltlab.com"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.pluginStore{/lang}</a></li>
                                </ul>
                        </li>
                {/if}
diff --git a/wcfsetup/install/files/acp/templates/pageMenuMobile.tpl b/wcfsetup/install/files/acp/templates/pageMenuMobile.tpl
index 259fd57b231521c5be25f8fdee1ab9b4264608d7..1f352acbb3bb4c7a13dbf4423f4694cc1fd4119e 100644 (file)
--- a/wcfsetup/install/files/acp/templates/pageMenuMobile.tpl
+++ b/wcfsetup/install/files/acp/templates/pageMenuMobile.tpl
@@ -66,11 +66,11 @@
                                        <span class="menuOverlayItemTitle">WoltLab&reg;</span>
                                </a>
                                <ol class="menuOverlayItemList">
-                                       <li class="menuOverlayItem"><a href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.website{/lang}</a></li>
-                                       <li class="menuOverlayItem"><a href="https://manual.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de{else}en{/if}/" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.manual{/lang}</a></li>
-                                       <li class="menuOverlayItem"><a href="https://community.woltlab.com" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.forums{/lang}</a></li>
-                                       <li class="menuOverlayItem"><a href="https://www.woltlab.com/ticket-add/" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.tickets{/lang}</a></li>
-                                       <li class="menuOverlayItem"><a href="https://pluginstore.woltlab.com" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank"{/if}>{lang}wcf.acp.index.woltlab.pluginStore{/lang}</a></li>
+                                       <li class="menuOverlayItem"><a href="https://www.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de/{/if}" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.website{/lang}</a></li>
+                                       <li class="menuOverlayItem"><a href="https://manual.woltlab.com/{if $__wcf->getLanguage()->getFixedLanguageCode() === 'de'}de{else}en{/if}/" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.manual{/lang}</a></li>
+                                       <li class="menuOverlayItem"><a href="https://community.woltlab.com" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.forums{/lang}</a></li>
+                                       <li class="menuOverlayItem"><a href="https://www.woltlab.com/ticket-add/" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.tickets{/lang}</a></li>
+                                       <li class="menuOverlayItem"><a href="https://pluginstore.woltlab.com" class="menuOverlayItemLink"{if EXTERNAL_LINK_TARGET_BLANK} target="_blank" rel="noopener"{/if}>{lang}wcf.acp.index.woltlab.pluginStore{/lang}</a></li>
                                </ol>
                        </li>
                        <li class="menuOverlayTitle">{$__wcf->user->username}</li>
WoltLab Suite Core (previously WoltLab Community Framework)