Remove useless WCFSetup workaround in SessionHandler::needsReauthentication()

Apparently I did not conduct my testing properly yesterday and piled on
non-effective workarounds for the WCFSetup issue. This one is particularly bad,
because I inverted the condition, disabling reauthentication everywhere, except
in WCFSetup.

Thus this patch removes this buggy workaround again.

see ff5d8cec55f0a953a353165b2d996f84a56838f6
see 4b5f3b084ef062b48eaba18b3f497ba89743ddcd

diff --git a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
index ca0df2c247a64b58a07f96a706224454c3bac5a5..94edee86fdacf8e5b51385c4cedf24e3f568a793 100644 (file)
--- a/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
+++ b/wcfsetup/install/files/lib/system/session/SessionHandler.class.php
@@ -1039,11 +1039,6 @@ final class SessionHandler extends SingletonFactory
             throw new \BadMethodCallException('The current user is a guest.');
         }
 
-        // Workaround during WCFSetup.
-        if (PACKAGE_ID) {
-            return false;
-        }
-
         // Reauthentication for third party authentication is not supported.
         if ($this->getUser()->authData) {
             return false;