rtc: rx8025: round up to nearest minute for a minute accuracy alarm
authorAkinobu Mita <akinobu.mita@gmail.com>
Mon, 15 Feb 2016 14:49:08 +0000 (23:49 +0900)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Mon, 14 Mar 2016 16:08:20 +0000 (17:08 +0100)
The alarm for rx8025 only has a minute accuracy, so round up to nearest
minute when setting alarm.  Without doing this, rtctest blocks one day
after setting alarm to 5 seconds later.

pcf8563 and hym8563 also have similar handling.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-rx8025.c

index 259995281e0df910a6bac4438fe5696a99a07bea..e117a8f6d025e259fe1e515fdb1daa190d90717c 100644 (file)
@@ -344,7 +344,17 @@ static int rx8025_set_alarm(struct device *dev, struct rtc_wkalrm *t)
        if (client->irq <= 0)
                return -EINVAL;
 
-       /* Hardware alarm precision is 1 minute! */
+       /*
+        * Hardware alarm precision is 1 minute!
+        * round up to nearest minute
+        */
+       if (t->time.tm_sec) {
+               time64_t alarm_time = rtc_tm_to_time64(&t->time);
+
+               alarm_time += 60 - t->time.tm_sec;
+               rtc_time64_to_tm(alarm_time, &t->time);
+       }
+
        ald[0] = bin2bcd(t->time.tm_min);
        if (rx8025->ctrl1 & RX8025_BIT_CTRL1_1224)
                ald[1] = bin2bcd(t->time.tm_hour);