tracing/core: fix early free of cpumasks
authorFrederic Weisbecker <fweisbec@gmail.com>
Mon, 16 Mar 2009 00:45:03 +0000 (01:45 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 16 Mar 2009 08:13:18 +0000 (09:13 +0100)
Impact: fix crashes when tracing cpumasks

While ring-buffer allocation, the cpumasks are allocated too,
including the tracing cpumask and the per-cpu file mask handler.
But these cpumasks are freed accidentally just after.
Fix it.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1237164303-11476-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/trace.c

index c0cf946d42f574843b5a95836f282cc89899abe4..ae32d3b99b4b07b55509f7145598bc783b8ace41 100644 (file)
@@ -4125,7 +4125,8 @@ __init static int tracer_alloc_buffers(void)
                                       &trace_panic_notifier);
 
        register_die_notifier(&trace_die_notifier);
-       ret = 0;
+
+       return 0;
 
 out_free_cpumask:
        free_cpumask_var(tracing_reader_cpumask);