drm/exynos: dsi: move the EoT packets configuration point

This configuration could be used in MIPI DSI command mode also.
And adds user manual description for display configuration.

Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 2df3592166def1338f238b5aabc753cdcff1c21a..58bfb2a2a19b2da1f40c5a85b08a42dff07f8897 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -468,13 +468,20 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
        /* DSI configuration */
        reg = 0;
 
+       /*
+        * The first bit of mode_flags specifies display configuration.
+        * If this bit is set[= MIPI_DSI_MODE_VIDEO], dsi will support video
+        * mode, otherwise it will support command mode.
+        */
        if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) {
                reg |= DSIM_VIDEO_MODE;
 
+               /*
+                * The user manual describes that following bits are ignored in
+                * command mode.
+                */
                if (!(dsi->mode_flags & MIPI_DSI_MODE_VSYNC_FLUSH))
                        reg |= DSIM_MFLUSH_VS;
-               if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET))
-                       reg |= DSIM_EOT_DISABLE;
                if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
                        reg |= DSIM_SYNC_INFORM;
                if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
@@ -491,6 +498,9 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
                        reg |= DSIM_HSA_MODE;
        }
 
+       if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET))
+               reg |= DSIM_EOT_DISABLE;
+
        switch (dsi->format) {
        case MIPI_DSI_FMT_RGB888:
                reg |= DSIM_MAIN_PIX_FORMAT_RGB888;