projects / GitHub / LineageOS / android_hardware_samsung_slsi_exynos5.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 405cc12)
exynos_omx: Do not call memset on object to be freed
authorSeungBeom Kim <sbcrux.kim@samsung.com>
Thu, 27 Sep 2012 19:40:28 +0000 (12:40 -0700)
committerDima Zavin <dima@android.com>
Fri, 28 Sep 2012 18:52:29 +0000 (11:52 -0700)
pointer could be null, in which case free would succeed
but we first called memset() and things exploded.

Fixes a crash when video editor test attempts to export video
with multiple transitions.

Bug: 7233929
Change-Id: Iac752effe2c239b218cfe3c7d46d1b0ad19b7080
Signed-off-by: SeungBeom Kim <sbcrux.kim@samsung.com>
exynos_omx/openmax/exynos_omx/core/Exynos_OMX_Component_Register.c patch | blob | blame | history

diff --git a/exynos_omx/openmax/exynos_omx/core/Exynos_OMX_Component_Register.c b/exynos_omx/openmax/exynos_omx/core/Exynos_OMX_Component_Register.c
index 04d5b491138db35ba9c348213366a80277a1ae53..f44dcdc0855eccab55f72285d2bb547560f00126 100644 (file)
--- a/exynos_omx/openmax/exynos_omx/core/Exynos_OMX_Component_Register.c
+++ b/exynos_omx/openmax/exynos_omx/core/Exynos_OMX_Component_Register.c
@@ -141,7 +141,6 @@ OMX_ERRORTYPE Exynos_OMX_Component_Unregister(EXYNOS_OMX_COMPONENT_REGLIST *comp
 {
     OMX_ERRORTYPE ret = OMX_ErrorNone;
 
-    Exynos_OSAL_Memset(componentList, 0, sizeof(EXYNOS_OMX_COMPONENT_REGLIST) * MAX_OMX_COMPONENT_NUM);
     Exynos_OSAL_Free(componentList);
 
 EXIT: