pinctrl: amd: fix error return code in amd_gpio_probe()

platform_get_irq() returns an error code, but the pinctrl-amd driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index e6779d4352a277fe386c858c5ec7a6c8d73a9fc3..38af1ec2df0c2b9c172915906f0a63864b65f1b5 100644 (file)
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -760,8 +760,8 @@ static int amd_gpio_probe(struct platform_device *pdev)
 
        irq_base = platform_get_irq(pdev, 0);
        if (irq_base < 0) {
-               dev_err(&pdev->dev, "Failed to get gpio IRQ.\n");
-               return -EINVAL;
+               dev_err(&pdev->dev, "Failed to get gpio IRQ: %d\n", irq_base);
+               return irq_base;
        }
 
        gpio_dev->pdev = pdev;