projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 580693b)
usb: gadget: amd5536udc: use WARN_ON
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 22 Sep 2015 13:24:28 +0000 (18:54 +0530)
committerFelipe Balbi <balbi@ti.com>
Thu, 1 Oct 2015 17:40:20 +0000 (12:40 -0500)
Use WARN_ON() instead of halting the kernel with BUG_ON() and also fix
the checkpatch warning.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/amd5536udc.c patch | blob | blame | history

diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/udc/amd5536udc.c
index 3f85044be196486790ca365c33b3b1a72385a1d7..6223b1be029f9f39fecc969a6b408760f0a84e58 100644 (file)
--- a/drivers/usb/gadget/udc/amd5536udc.c
+++ b/drivers/usb/gadget/udc/amd5536udc.c
@@ -3127,7 +3127,8 @@ static void udc_pci_remove(struct pci_dev *pdev)
 
        usb_del_gadget_udc(&udc->gadget);
        /* gadget driver must not be registered */
-       BUG_ON(dev->driver != NULL);
+       if (WARN_ON(dev->driver))
+               return;
 
        /* dma pool cleanup */
        if (dev->data_requests)