x86/xen: only warn once if bad MFNs are found during setup
authorDavid Vrabel <david.vrabel@citrix.com>
Tue, 7 Jan 2014 11:36:53 +0000 (11:36 +0000)
committerDavid Vrabel <david.vrabel@citrix.com>
Thu, 15 May 2014 15:15:01 +0000 (16:15 +0100)
In xen_add_extra_mem(), if the WARN() checks for bad MFNs trigger it is
likely that they will trigger at lot, spamming the log.

Use WARN_ONCE() instead.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
arch/x86/xen/setup.c

index 0982233b9b8433a97d6905de4aad3369c6f4c0a5..2afe55e21d594ce7ef6b02af993621a7ef944806 100644 (file)
@@ -89,10 +89,10 @@ static void __init xen_add_extra_mem(u64 start, u64 size)
        for (pfn = PFN_DOWN(start); pfn < xen_max_p2m_pfn; pfn++) {
                unsigned long mfn = pfn_to_mfn(pfn);
 
-               if (WARN(mfn == pfn, "Trying to over-write 1-1 mapping (pfn: %lx)\n", pfn))
+               if (WARN_ONCE(mfn == pfn, "Trying to over-write 1-1 mapping (pfn: %lx)\n", pfn))
                        continue;
-               WARN(mfn != INVALID_P2M_ENTRY, "Trying to remove %lx which has %lx mfn!\n",
-                       pfn, mfn);
+               WARN_ONCE(mfn != INVALID_P2M_ENTRY, "Trying to remove %lx which has %lx mfn!\n",
+                         pfn, mfn);
 
                __set_phys_to_machine(pfn, INVALID_P2M_ENTRY);
        }