random: Adjust the number of loops when initializing
authorH. Peter Anvin <hpa@linux.intel.com>
Mon, 16 Jan 2012 19:23:29 +0000 (11:23 -0800)
committerH. Peter Anvin <hpa@linux.intel.com>
Mon, 16 Jan 2012 19:33:49 +0000 (11:33 -0800)
When we are initializing using arch_get_random_long() we only need to
loop enough times to touch all the bytes in the buffer; using
poolwords for that does twice the number of operations necessary on a
64-bit machine, since in the random number generator code "word" means
32 bits.

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Link: http://lkml.kernel.org/r/1324589281-31931-1-git-send-email-tytso@mit.edu
drivers/char/random.c

index 30794779c523048e3d1f1a27a9aa014b84a775ee..9a2156d77629f111d9e98a922d70cb665494ee0d 100644 (file)
@@ -975,7 +975,7 @@ static void init_std_data(struct entropy_store *r)
 
        now = ktime_get_real();
        mix_pool_bytes(r, &now, sizeof(now));
-       for (i = r->poolinfo->poolwords; i; i--) {
+       for (i = r->poolinfo->POOLBYTES; i > 0; i -= sizeof flags) {
                if (!arch_get_random_long(&flags))
                        break;
                mix_pool_bytes(r, &flags, sizeof(flags));