lustre: lov: Drop rq_buflen field
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 8 Jun 2015 12:53:20 +0000 (14:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Jun 2015 19:39:48 +0000 (12:39 -0700)
The rq_buflen field of the lov_request structure is never initialized.  It
is only used in the free of req->rq_oi.oi_md in lov_finish_set.  But no
oi_md field is ever initialized to the result of calling OBD_ALLOC_LARGE.
So it seems that the call to OBD_FREE_LARGE in lov_finish_set and the
rq_buflen in the lov_request structure are simply not needed.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/lov/lov_internal.h
drivers/staging/lustre/lustre/lov/lov_request.c

index e4e0cfdfd8ea545028a7e126737aa10c404993da..dde9656d4dd61b4b8bdb7bac17c7697fd3d0ffd6 100644 (file)
@@ -81,7 +81,6 @@ struct lov_request {
        int                   rq_stripe;     /* stripe number */
        int                   rq_complete;
        int                   rq_rc;
-       int                   rq_buflen;     /* length of sub_md */
 
        u32                   rq_oabufs;
        u32                   rq_pgaidx;
index ada0a3cf1c0f1f35cfd3e4688a1c8ec3bfcd1f8d..f4f2058abd2ba2cd4d1d95c194aeba87332551de 100644 (file)
@@ -68,8 +68,6 @@ void lov_finish_set(struct lov_request_set *set)
 
                if (req->rq_oi.oi_oa)
                        OBDO_FREE(req->rq_oi.oi_oa);
-               if (req->rq_oi.oi_md)
-                       OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
                kfree(req->rq_oi.oi_osfs);
                kfree(req);
        }