tty: Replace ASYNC_CHECK_CD and update atomically

Replace ASYNC_CHECK_CD bit in the tty_port::flags field with
TTY_PORT_CHECK_CD bit in the tty_port::iflags field. Introduce helpers
tty_port_set_check_carrier() and tty_port_check_carrier() to abstract
the atomic bit ops.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index bdf41ac613dcafc07ede732f1f5a96bfe73addeb..bf54f4e23b6f86efea7b08f62378e03d683362d6 100644 (file)
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -1101,7 +1101,7 @@ static void dcd_change(MGSLPC_INFO *info, struct tty_struct *tty)
        wake_up_interruptible(&info->status_event_wait_q);
        wake_up_interruptible(&info->event_wait_q);
 
-       if (info->port.flags & ASYNC_CHECK_CD) {
+       if (tty_port_check_carrier(&info->port)) {
                if (debug_level >= DEBUG_LEVEL_ISR)
                        printk("%s CD now %s...", info->device_name,
                               (info->serial_signals & SerialSignal_DCD) ? "on" : "off");
@@ -1467,11 +1467,7 @@ static void mgslpc_change_params(MGSLPC_INFO *info, struct tty_struct *tty)
        info->timeout += HZ/50;         /* Add .02 seconds of slop */
 
        tty_port_set_cts_flow(&info->port, cflag & CRTSCTS);
-
-       if (cflag & CLOCAL)
-               info->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               info->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
        /* process tty input control flags */
 

diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
index d8468f3529a7c9fca2b1b0dd5cfd09e4915a11fc..023a350a8cd800b0d0a377fd55756a3c7dc7b4c5 100644 (file)
--- a/drivers/isdn/i4l/isdn_tty.c
+++ b/drivers/isdn/i4l/isdn_tty.c
@@ -1043,11 +1043,7 @@ isdn_tty_change_speed(modem_info *info)
        if (!(cflag & PARODD))
                cval |= UART_LCR_EPAR;
 
-       if (cflag & CLOCAL)
-               port->flags &= ~ASYNC_CHECK_CD;
-       else {
-               port->flags |= ASYNC_CHECK_CD;
-       }
+       tty_port_set_check_carrier(port, ~cflag & CLOCAL);
 }
 
 static int
@@ -2526,7 +2522,7 @@ isdn_tty_modem_result(int code, modem_info *info)
                if (info->closing || (!info->port.tty))
                        return;
 
-               if (info->port.flags & ASYNC_CHECK_CD)
+               if (tty_port_check_carrier(&info->port))
                        tty_hangup(info->port.tty);
        }
 }

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 80d61658efb04c161eb8dd4dbc6fd8377df83b39..b4ab97d563517c5db47d1aee9aea2c58a714d18f 100644 (file)
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -398,7 +398,7 @@ static void check_modem_status(struct serial_state *info)
                wake_up_interruptible(&port->delta_msr_wait);
        }
 
-       if ((port->flags & ASYNC_CHECK_CD) && (dstatus & SER_DCD)) {
+       if (tty_port_check_carrier(port) && (dstatus & SER_DCD)) {
 #if (defined(SERIAL_DEBUG_OPEN) || defined(SERIAL_DEBUG_INTR))
                printk("ttyS%d CD now %s...", info->line,
                       (!(status & SER_DCD)) ? "on" : "off");
@@ -730,12 +730,9 @@ static void change_speed(struct tty_struct *tty, struct serial_state *info,
        tty_port_set_cts_flow(port, cflag & CRTSCTS);
        if (cflag & CRTSCTS)
                info->IER |= UART_IER_MSI;
-       if (cflag & CLOCAL)
-               port->flags &= ~ASYNC_CHECK_CD;
-       else {
-               port->flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(port, ~cflag & CLOCAL);
+       if (~cflag & CLOCAL)
                info->IER |= UART_IER_MSI;
-       }
        /* TBD:
         * Does clearing IER_MSI imply that we should disable the VBL interrupt ?
         */

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 1a12776ba24c03d14a4a3ae8d47acaa53cd27e56..9d1e19ba25cbe2dac2b9340eed72bab0e7445b3a 100644 (file)
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -714,7 +714,7 @@ static void cyy_chip_modem(struct cyclades_card *cinfo, int chip,
                wake_up_interruptible(&info->port.delta_msr_wait);
        }
 
-       if ((mdm_change & CyDCD) && (info->port.flags & ASYNC_CHECK_CD)) {
+       if ((mdm_change & CyDCD) && tty_port_check_carrier(&info->port)) {
                if (mdm_status & CyDCD)
                        wake_up_interruptible(&info->port.open_wait);
                else
@@ -1119,7 +1119,7 @@ static void cyz_handle_cmd(struct cyclades_card *cinfo)
                case C_CM_MDCD:
                        info->icount.dcd++;
                        delta_count++;
-                       if (info->port.flags & ASYNC_CHECK_CD) {
+                       if (tty_port_check_carrier(&info->port)) {
                                u32 dcd = fw_ver > 241 ? param :
                                        readl(&info->u.cyz.ch_ctrl->rs_status);
                                if (dcd & C_RS_DCD)
@@ -2088,10 +2088,7 @@ static void cy_set_line_char(struct cyclades_port *info, struct tty_struct *tty)
                        info->cor2 |= CyCtsAE;
                else
                        info->cor2 &= ~CyCtsAE;
-               if (cflag & CLOCAL)
-                       info->port.flags &= ~ASYNC_CHECK_CD;
-               else
-                       info->port.flags |= ASYNC_CHECK_CD;
+               tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
         /***********************************************
            The hardware option, CyRtsAO, presents RTS when
@@ -2250,10 +2247,7 @@ static void cy_set_line_char(struct cyclades_port *info, struct tty_struct *tty)
                }
 
                /* CD sensitivity */
-               if (cflag & CLOCAL)
-                       info->port.flags &= ~ASYNC_CHECK_CD;
-               else
-                       info->port.flags |= ASYNC_CHECK_CD;
+               tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
                if (baud == 0) {        /* baud rate is zero, turn off line */
                        cy_writel(&ch_ctrl->rs_control,

diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
index c5f06b54b9ca8caf323c0a2f429b762e9f8c91d8..0b2bae1b2d559fdded7dffa3ae694580aa96a0a9 100644 (file)
--- a/drivers/tty/isicom.c
+++ b/drivers/tty/isicom.c
@@ -577,7 +577,7 @@ static irqreturn_t isicom_interrupt(int irq, void *dev_id)
                header = inw(base);
                switch (header & 0xff) {
                case 0: /* Change in EIA signals */
-                       if (port->port.flags & ASYNC_CHECK_CD) {
+                       if (tty_port_check_carrier(&port->port)) {
                                if (port->status & ISI_DCD) {
                                        if (!(header & ISI_DCD)) {
                                        /* Carrier has been lost  */
@@ -758,10 +758,7 @@ static void isicom_config_port(struct tty_struct *tty)
                outw(channel_setup, base);
                InterruptTheCard(base);
        }
-       if (C_CLOCAL(tty))
-               port->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               port->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&port->port, !C_CLOCAL(tty));
 
        /* flow control settings ...*/
        flow_ctrl = 0;

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 8f3fdad37ac7626b78a987b6897c4eb131dbacf5..ab618ef3d171bbc0d91e44c6ced6e552b65f496f 100644 (file)
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
@@ -746,12 +746,9 @@ static int mxser_change_speed(struct tty_struct *tty,
                }
        }
        outb(info->MCR, info->ioaddr + UART_MCR);
-       if (cflag & CLOCAL) {
-               info->port.flags &= ~ASYNC_CHECK_CD;
-       } else {
-               info->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
+       if (~cflag & CLOCAL)
                info->IER |= UART_IER_MSI;
-       }
        outb(info->IER, info->ioaddr + UART_IER);
 
        /*
@@ -824,7 +821,7 @@ static void mxser_check_modem_status(struct tty_struct *tty,
        port->mon_data.modem_status = status;
        wake_up_interruptible(&port->port.delta_msr_wait);
 
-       if ((port->port.flags & ASYNC_CHECK_CD) && (status & UART_MSR_DDCD)) {
+       if (tty_port_check_carrier(&port->port) && (status & UART_MSR_DDCD)) {
                if (status & UART_MSR_DCD)
                        wake_up_interruptible(&port->port.open_wait);
        }

diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
index b55f8468cde5e924f1ce3f03ed0bc256994c1865..b67b54a800bb7ff399b785d83f0e81fd1936ba99 100644 (file)
--- a/drivers/tty/synclink.c
+++ b/drivers/tty/synclink.c
@@ -1340,7 +1340,7 @@ static void mgsl_isr_io_pin( struct mgsl_struct *info )
                wake_up_interruptible(&info->status_event_wait_q);
                wake_up_interruptible(&info->event_wait_q);
 
-               if ( (info->port.flags & ASYNC_CHECK_CD) && 
+               if (tty_port_check_carrier(&info->port) &&
                     (status & MISCSTATUS_DCD_LATCHED) ) {
                        if ( debug_level >= DEBUG_LEVEL_ISR )
                                printk("%s CD now %s...", info->device_name,
@@ -1967,11 +1967,7 @@ static void mgsl_change_params(struct mgsl_struct *info)
        info->timeout += HZ/50;         /* Add .02 seconds of slop */
 
        tty_port_set_cts_flow(&info->port, cflag & CRTSCTS);
-
-       if (cflag & CLOCAL)
-               info->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               info->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
        /* process tty input control flags */
        

diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
index c76f546697dcc05b1ad8fb2a7a15230053244a43..333652a8896ad060ce4a0c807855a7c31970c2fb 100644 (file)
--- a/drivers/tty/synclink_gt.c
+++ b/drivers/tty/synclink_gt.c
@@ -2080,7 +2080,7 @@ static void dcd_change(struct slgt_info *info, unsigned short status)
        wake_up_interruptible(&info->event_wait_q);
        info->pending_bh |= BH_STATUS;
 
-       if (info->port.flags & ASYNC_CHECK_CD) {
+       if (tty_port_check_carrier(&info->port)) {
                if (info->signals & SerialSignal_DCD)
                        wake_up_interruptible(&info->port.open_wait);
                else {
@@ -2577,11 +2577,7 @@ static void change_params(struct slgt_info *info)
        info->timeout += HZ/50;         /* Add .02 seconds of slop */
 
        tty_port_set_cts_flow(&info->port, cflag & CRTSCTS);
-
-       if (cflag & CLOCAL)
-               info->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               info->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
        /* process tty input control flags */
 

diff --git a/drivers/tty/synclinkmp.c b/drivers/tty/synclinkmp.c
index 95eddc4d9eb814870cc40f3b3aa88b8c9b626bfb..17bab5f5b858c92b78a1cb10e830835425fbe121 100644 (file)
--- a/drivers/tty/synclinkmp.c
+++ b/drivers/tty/synclinkmp.c
@@ -2463,7 +2463,7 @@ static void isr_io_pin( SLMP_INFO *info, u16 status )
                wake_up_interruptible(&info->status_event_wait_q);
                wake_up_interruptible(&info->event_wait_q);
 
-               if ( (info->port.flags & ASYNC_CHECK_CD) &&
+               if (tty_port_check_carrier(&info->port) &&
                     (status & MISCSTATUS_DCD_LATCHED) ) {
                        if ( debug_level >= DEBUG_LEVEL_ISR )
                                printk("%s CD now %s...", info->device_name,
@@ -2814,11 +2814,7 @@ static void change_params(SLMP_INFO *info)
        info->timeout += HZ/50;         /* Add .02 seconds of slop */
 
        tty_port_set_cts_flow(&info->port, cflag & CRTSCTS);
-
-       if (cflag & CLOCAL)
-               info->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               info->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&info->port, ~cflag & CLOCAL);
 
        /* process tty input control flags */
 

diff --git a/include/linux/tty.h b/include/linux/tty.h
index dbeeb8666ae4f6869d0587c1547ce694eadbce36..4254dfb12fb1b52df2b629ede81404ee09e853f8 100644 (file)
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -584,6 +584,19 @@ static inline void tty_port_set_active(struct tty_port *port, bool val)
                clear_bit(TTY_PORT_ACTIVE, &port->iflags);
 }
 
+static inline bool tty_port_check_carrier(struct tty_port *port)
+{
+       return test_bit(TTY_PORT_CHECK_CD, &port->iflags);
+}
+
+static inline void tty_port_set_check_carrier(struct tty_port *port, bool val)
+{
+       if (val)
+               set_bit(TTY_PORT_CHECK_CD, &port->iflags);
+       else
+               clear_bit(TTY_PORT_CHECK_CD, &port->iflags);
+}
+
 extern struct tty_struct *tty_port_tty_get(struct tty_port *port);
 extern void tty_port_tty_set(struct tty_port *port, struct tty_struct *tty);
 extern int tty_port_carrier_raised(struct tty_port *port);

diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c
index 681fe0bfe5589e1e9361598579f8bf9d50a20040..5b7ce599c709dae778ffced29d65713517455709 100644 (file)
--- a/net/irda/ircomm/ircomm_tty.c
+++ b/net/irda/ircomm/ircomm_tty.c
@@ -999,7 +999,7 @@ void ircomm_tty_check_modem_status(struct ircomm_tty_cb *self)
        if (status & IRCOMM_DCE_DELTA_ANY) {
                /*wake_up_interruptible(&self->delta_msr_wait);*/
        }
-       if ((self->port.flags & ASYNC_CHECK_CD) && (status & IRCOMM_DELTA_CD)) {
+       if (tty_port_check_carrier(&self->port) && (status & IRCOMM_DELTA_CD)) {
                pr_debug("%s(), ircomm%d CD now %s...\n", __func__ , self->line,
                         (status & IRCOMM_CD) ? "on" : "off");
 
@@ -1255,7 +1255,7 @@ static void ircomm_tty_line_info(struct ircomm_tty_cb *self, struct seq_file *m)
                seq_printf(m, "%cASYNC_CTS_FLOW", sep);
                sep = '|';
        }
-       if (self->port.flags & ASYNC_CHECK_CD) {
+       if (tty_port_check_carrier(&self->port)) {
                seq_printf(m, "%cASYNC_CHECK_CD", sep);
                sep = '|';
        }

diff --git a/net/irda/ircomm/ircomm_tty_attach.c b/net/irda/ircomm/ircomm_tty_attach.c
index 61137f8b5293617c789172cf5c1840417cb7efa6..0a411019c09864206beedde16bf87532cae651b6 100644 (file)
--- a/net/irda/ircomm/ircomm_tty_attach.c
+++ b/net/irda/ircomm/ircomm_tty_attach.c
@@ -968,7 +968,7 @@ static int ircomm_tty_state_ready(struct ircomm_tty_cb *self,
                ircomm_tty_next_state(self, IRCOMM_TTY_SEARCH);
                ircomm_tty_start_watchdog_timer(self, 3*HZ);
 
-               if (self->port.flags & ASYNC_CHECK_CD) {
+               if (tty_port_check_carrier(&self->port)) {
                        /* Drop carrier */
                        self->settings.dce = IRCOMM_DELTA_CD;
                        ircomm_tty_check_modem_status(self);

diff --git a/net/irda/ircomm/ircomm_tty_ioctl.c b/net/irda/ircomm/ircomm_tty_ioctl.c
index 1220973c7c43017512cad843b314464e69dc75f0..e24724db36a270a33bd00b1f97a1ca261b97c3ce 100644 (file)
--- a/net/irda/ircomm/ircomm_tty_ioctl.c
+++ b/net/irda/ircomm/ircomm_tty_ioctl.c
@@ -96,10 +96,7 @@ static void ircomm_tty_change_speed(struct ircomm_tty_cb *self,
        } else {
                self->settings.flow_control &= ~IRCOMM_RTS_CTS_IN;
        }
-       if (cflag & CLOCAL)
-               self->port.flags &= ~ASYNC_CHECK_CD;
-       else
-               self->port.flags |= ASYNC_CHECK_CD;
+       tty_port_set_check_carrier(&self->port, ~cflag & CLOCAL);
 #if 0
        /*
         * Set up parity check flag