projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0eab65c)
iio: adc: twl6030-gpadc: fix error return code in twl6030_gpadc_read_raw()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 23 Aug 2013 02:47:00 +0000 (03:47 +0100)
committerJonathan Cameron <jic23@kernel.org>
Wed, 28 Aug 2013 19:45:43 +0000 (20:45 +0100)
Fix to return -EINTR in the error handling case instead
of 0 (ret is assigned after goto, which has no effect),
as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/twl6030-gpadc.c patch | blob | blame | history

diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index a558516d140d22e596b9d446dd1b3afa728722c4..0ea96c058c0880016de8ec9c1b01b9f20c0cd9b0 100644 (file)
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
                ret = -ETIMEDOUT;
                goto err;
        } else if (timeout < 0) {
-               goto err;
                ret = -EINTR;
+               goto err;
        }
 
        switch (mask) {