projects
/
GitHub
/
LineageOS
/
android_kernel_samsung_universal7580.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
196b7e1
)
SMSC: timeout reaches -1
author
Roel Kluin
<roel.kluin@gmail.com>
Fri, 20 Feb 2009 08:52:19 +0000
(
00:52
-0800)
committer
David S. Miller
<davem@davemloft.net>
Fri, 20 Feb 2009 08:52:19 +0000
(
00:52
-0800)
With a postfix decrement timeouts will reach -1 rather than 0, so
the error path does not appear.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smsc911x.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/smsc911x.c
b/drivers/net/smsc911x.c
index 783c1a7b869e62c20ccf1981cbe3000f5eaddf56..9a78daec2fe9268d3972f3dc8e3206cb6c2e46c8 100644
(file)
--- a/
drivers/net/smsc911x.c
+++ b/
drivers/net/smsc911x.c
@@
-1624,7
+1624,7
@@
static int smsc911x_eeprom_send_cmd(struct smsc911x_data *pdata, u32 op)
do {
msleep(1);
e2cmd = smsc911x_reg_read(pdata, E2P_CMD);
- } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (
timeout--
));
+ } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (
--timeout
));
if (!timeout) {
SMSC_TRACE(DRV, "TIMED OUT");