Closing dialogs with Esc should close and detach the dialog

See https://www.woltlab.com/community/thread/300742-seite-nicht-mehr-scrollbar-wenn-dialog-mittels-esc-geschlossen-wird/

diff --git a/ts/WoltLabSuite/Core/Element/woltlab-core-dialog.ts b/ts/WoltLabSuite/Core/Element/woltlab-core-dialog.ts
index aaa1b4ac5af0887d1a9cec5b92166cabd5747c9c..39aceafb26dcf49bae110495f4963c87d5130c13 100644 (file)
--- a/ts/WoltLabSuite/Core/Element/woltlab-core-dialog.ts
+++ b/ts/WoltLabSuite/Core/Element/woltlab-core-dialog.ts
@@ -277,6 +277,8 @@ export class WoltlabCoreDialogElement extends HTMLElement {
         event.preventDefault();
         return;
       }
+
+      this.#detachDialog();
     });
 
     // Close the dialog by clicking on the backdrop.

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Element/woltlab-core-dialog.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Element/woltlab-core-dialog.js
index 618d373e8be7b4984407453816301da19665b8b0..c8b024a24e7487c33ce7b05d6150029986503453 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Element/woltlab-core-dialog.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Element/woltlab-core-dialog.js
@@ -211,6 +211,7 @@ define(["require", "exports", "tslib", "../Dom/Util", "../Helper/PageOverlay", "
                     event.preventDefault();
                     return;
                 }
+                this.#detachDialog();
             });
             // Close the dialog by clicking on the backdrop.
             //