MIPS: Don't corrupt page tables on vmalloc fault.
authorDavid Daney <ddaney@caviumnetworks.com>
Wed, 2 Sep 2009 22:47:34 +0000 (15:47 -0700)
committerRalf Baechle <ralf@linux-mips.org>
Thu, 17 Sep 2009 18:07:52 +0000 (20:07 +0200)
The code after the vmalloc_fault: label in do_page_fault() modifies
user page tables, this is not correct for 64-bit kernels.

For 64-bit kernels we should go straight to the no_context handler
skipping vmalloc_fault.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/mm/fault.c

index f956ecbb81363af8a55b4d0179e7b3b9abc50ca8..e97a7a2fb2c0980346c75791fce09b4026ee334b 100644 (file)
@@ -58,11 +58,17 @@ asmlinkage void do_page_fault(struct pt_regs *regs, unsigned long write,
         * only copy the information from the master page table,
         * nothing more.
         */
+#ifdef CONFIG_64BIT
+# define VMALLOC_FAULT_TARGET no_context
+#else
+# define VMALLOC_FAULT_TARGET vmalloc_fault
+#endif
+
        if (unlikely(address >= VMALLOC_START && address <= VMALLOC_END))
-               goto vmalloc_fault;
+               goto VMALLOC_FAULT_TARGET;
 #ifdef MODULE_START
        if (unlikely(address >= MODULE_START && address < MODULE_END))
-               goto vmalloc_fault;
+               goto VMALLOC_FAULT_TARGET;
 #endif
 
        /*
@@ -203,6 +209,7 @@ do_sigbus:
        force_sig_info(SIGBUS, &info, tsk);
 
        return;
+#ifndef CONFIG_64BIT
 vmalloc_fault:
        {
                /*
@@ -241,4 +248,5 @@ vmalloc_fault:
                        goto no_context;
                return;
        }
+#endif
 }