regulator: qcom_smd: Handle big endian CPUs
authorStephen Boyd <sboyd@codeaurora.org>
Wed, 2 Sep 2015 22:46:51 +0000 (15:46 -0700)
committerMark Brown <broonie@kernel.org>
Wed, 2 Sep 2015 23:11:01 +0000 (00:11 +0100)
The smd rpm structures are always in little endian, but this
driver is not capable of being used on big endian CPUs. Annotate
the little endian data members and update the code to do the
proper byte swapping.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom_smd-regulator.c

index 9c6167dd2c8b2890e35a3e823e32193345b30ac2..b72c693e29ffcb8f81e6df547dc9f701eaaab5bb 100644 (file)
@@ -36,9 +36,9 @@ struct qcom_rpm_reg {
 };
 
 struct rpm_regulator_req {
-       u32 key;
-       u32 nbytes;
-       u32 value;
+       __le32 key;
+       __le32 nbytes;
+       __le32 value;
 };
 
 #define RPM_KEY_SWEN   0x6e657773 /* "swen" */
@@ -62,9 +62,9 @@ static int rpm_reg_enable(struct regulator_dev *rdev)
        struct rpm_regulator_req req;
        int ret;
 
-       req.key = RPM_KEY_SWEN;
-       req.nbytes = sizeof(u32);
-       req.value = 1;
+       req.key = cpu_to_le32(RPM_KEY_SWEN);
+       req.nbytes = cpu_to_le32(sizeof(u32));
+       req.value = cpu_to_le32(1);
 
        ret = rpm_reg_write_active(vreg, &req, sizeof(req));
        if (!ret)
@@ -86,8 +86,8 @@ static int rpm_reg_disable(struct regulator_dev *rdev)
        struct rpm_regulator_req req;
        int ret;
 
-       req.key = RPM_KEY_SWEN;
-       req.nbytes = sizeof(u32);
+       req.key = cpu_to_le32(RPM_KEY_SWEN);
+       req.nbytes = cpu_to_le32(sizeof(u32));
        req.value = 0;
 
        ret = rpm_reg_write_active(vreg, &req, sizeof(req));
@@ -113,9 +113,9 @@ static int rpm_reg_set_voltage(struct regulator_dev *rdev,
        struct rpm_regulator_req req;
        int ret = 0;
 
-       req.key = RPM_KEY_UV;
-       req.nbytes = sizeof(u32);
-       req.value = min_uV;
+       req.key = cpu_to_le32(RPM_KEY_UV);
+       req.nbytes = cpu_to_le32(sizeof(u32));
+       req.value = cpu_to_le32(min_uV);
 
        ret = rpm_reg_write_active(vreg, &req, sizeof(req));
        if (!ret)
@@ -129,9 +129,9 @@ static int rpm_reg_set_load(struct regulator_dev *rdev, int load_uA)
        struct qcom_rpm_reg *vreg = rdev_get_drvdata(rdev);
        struct rpm_regulator_req req;
 
-       req.key = RPM_KEY_MA;
-       req.nbytes = sizeof(u32);
-       req.value = load_uA;
+       req.key = cpu_to_le32(RPM_KEY_MA);
+       req.nbytes = cpu_to_le32(sizeof(u32));
+       req.value = cpu_to_le32(load_uA);
 
        return rpm_reg_write_active(vreg, &req, sizeof(req));
 }