i4l: leak in eicon/idifunc.c
authorArmin Schindler <armin@melware.de>
Tue, 17 Jul 2007 11:04:23 +0000 (04:04 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:06 +0000 (10:23 -0700)
coverity spotted a possible leak in the idifunc.c file (bug id #1252), in
um_new_card(), if the diva_user_mode_idi_create_adapter() fails, we dont
free the memory allocated for card

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Armin Schindler <armin@melware.de>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/isdn/hardware/eicon/idifunc.c

index 4cbc68cf4dba2c7a744969e0ea49a5d37196d92b..db87d51054220121b7b529ac07b61bb4818335d7 100644 (file)
@@ -106,6 +106,7 @@ static void um_new_card(DESCRIPTOR * d)
        } else {
                DBG_ERR(("could not create user mode idi card %d",
                         adapter_nr));
+               diva_os_free(0, card);
        }
 }