[media] tvp5150: put endpoint node on error
authorJavier Martinez Canillas <javier@osg.samsung.com>
Fri, 5 Feb 2016 19:09:53 +0000 (17:09 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 10 Feb 2016 11:38:20 +0000 (09:38 -0200)
If the parallel mbus configuration is not correct, the endpoint
device node isn't currently put again in the error path. Fix it.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/tvp5150.c

index 19b52736b24e97236abf849bc1d1650410594d90..c7eeb59a999bcaf37b256dc8a95681e77f467681 100644 (file)
@@ -1268,8 +1268,10 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
        if (bus_cfg.bus_type == V4L2_MBUS_PARALLEL &&
            !(flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH &&
              flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH &&
-             flags & V4L2_MBUS_FIELD_EVEN_LOW))
-               return -EINVAL;
+             flags & V4L2_MBUS_FIELD_EVEN_LOW)) {
+               ret = -EINVAL;
+               goto err;
+       }
 
        decoder->mbus_type = bus_cfg.bus_type;