[media] saa7146: use swap() in sort_and_eliminate()

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

diff --git a/drivers/media/common/saa7146/saa7146_hlp.c b/drivers/media/common/saa7146/saa7146_hlp.c
index be746d1aee9a2afd94079c151a9ec1a22d01873c..3dc6a838ca6f745ba2b416029ed05ac2a08381c9 100644 (file)
--- a/drivers/media/common/saa7146/saa7146_hlp.c
+++ b/drivers/media/common/saa7146/saa7146_hlp.c
@@ -307,7 +307,7 @@ static int calculate_v_scale_registers(struct saa7146_dev *dev, enum v4l2_field
 /* simple bubble-sort algorithm with duplicate elimination */
 static int sort_and_eliminate(u32* values, int* count)
 {
-       int low = 0, high = 0, top = 0, temp = 0;
+       int low = 0, high = 0, top = 0;
        int cur = 0, next = 0;
 
        /* sanity checks */
@@ -318,11 +318,8 @@ static int sort_and_eliminate(u32* values, int* count)
        /* bubble sort the first @count items of the array @values */
        for( top = *count; top > 0; top--) {
                for( low = 0, high = 1; high < top; low++, high++) {
-                       if( values[low] > values[high] ) {
-                               temp = values[low];
-                               values[low] = values[high];
-                               values[high] = temp;
-                       }
+                       if( values[low] > values[high] )
+                               swap(values[low], values[high]);
                }
        }