[media] radio-wl1273: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:25 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:03:31 +0000 (19:03 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/radio/radio-wl1273.c

index 9b0c9fa0beb80307ac0a4b95785a2aaaa50fb0f3..6e55e93c0cf6c8abd5270f486b730cf4351dd3b8 100644 (file)
@@ -2084,8 +2084,7 @@ static int __devinit wl1273_fm_radio_probe(struct platform_device *pdev)
        }
 
        /* V4L2 configuration */
-       memcpy(&radio->videodev, &wl1273_viddev_template,
-              sizeof(wl1273_viddev_template));
+       radio->videodev = wl1273_viddev_template;
 
        radio->videodev.v4l2_dev = &radio->v4l2dev;