powerpc/module64: Fix comment in R_PPC64_ENTRY handling
authorMichael Ellerman <mpe@ellerman.id.au>
Fri, 5 Jul 2019 14:18:53 +0000 (00:18 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 09:42:57 +0000 (11:42 +0200)
commit 2fb0a2c989837c976b68233496bbaefb47cd3d6f upstream.

The comment here is wrong, the addi reads from r2 not r12. The code is
correct, 0x38420000 = addi r2,r2,0.

Fixes: a61674bdfc7c ("powerpc/module: Handle R_PPC64_ENTRY relocations")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/kernel/module_64.c

index 99407cf12ad5b51925e423ca0056e6d7a04833d8..e19dadffd9b7af2774046c887bd94408e3f7efc6 100644 (file)
@@ -691,7 +691,7 @@ int apply_relocate_add(Elf64_Shdr *sechdrs,
                        /*
                         * If found, replace it with:
                         *      addis r2, r12, (.TOC.-func)@ha
-                        *      addi r2, r12, (.TOC.-func)@l
+                        *      addi  r2,  r2, (.TOC.-func)@l
                         */
                        ((uint32_t *)location)[0] = 0x3c4c0000 + PPC_HA(value);
                        ((uint32_t *)location)[1] = 0x38420000 + PPC_LO(value);