Staging: rtl8188eu: Use put_unaligned_le32
authorVaishali Thakkar <vthakkar1994@gmail.com>
Fri, 31 Oct 2014 18:09:14 +0000 (23:39 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Nov 2014 00:10:38 +0000 (16:10 -0800)
This patch introduces the use of function put_unaligned_le32.

This is done using Coccinelle and semantic patch used is as follows:

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le32(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le32(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c

index 023a3d84ee8be97bcdf4df34563d06917d230cf9..ce55d9d9f0f633a7e1685f650fdbd97a018fe001 100644 (file)
@@ -150,11 +150,9 @@ u8 rtl8188e_set_raid_cmd(struct adapter *adapt, u32 mask)
        struct hal_data_8188e *haldata = GET_HAL_DATA(adapt);
 
        if (haldata->fw_ractrl) {
-               __le32 lmask;
 
                memset(buf, 0, 3);
-               lmask = cpu_to_le32(mask);
-               memcpy(buf, &lmask, 3);
+               put_unaligned_le32(mask, buf);
 
                FillH2CCmd_88E(adapt, H2C_DM_MACID_CFG, 3, buf);
        } else {